Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable EditIcon while loading filters (also fix loading filters) #1383

Merged
merged 3 commits into from
May 10, 2019

Conversation

swaterkamp
Copy link
Member

This will prevent a race condition when opening the EditDialog. Before this change, it was possible that the dialog opened before all settings (filters in particular) where loaded.

Checklist:

@swaterkamp swaterkamp self-assigned this May 9, 2019
@swaterkamp swaterkamp closed this May 9, 2019
@bjoernricks bjoernricks reopened this May 9, 2019
@swaterkamp swaterkamp changed the base branch from master to gsa-8.0 May 9, 2019 13:13
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #1383 into gsa-8.0 will increase coverage by 0.04%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1383      +/-   ##
===========================================
+ Coverage     36.1%   36.15%   +0.04%     
===========================================
  Files          960      960              
  Lines        21679    21652      -27     
  Branches      6014     6014              
===========================================
  Hits          7828     7828              
+ Misses       12515    12488      -27     
  Partials      1336     1336
Impacted Files Coverage Δ
gsa/src/web/pages/usersettings/dialog.js 30.76% <ø> (ø) ⬆️
gsa/src/gmp/commands/users.js 9.09% <ø> (ø) ⬆️
gsa/src/web/pages/usersettings/usersettingspage.js 3.54% <12.5%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be505ce...04d4714. Read the comment docs.

@swaterkamp swaterkamp marked this pull request as ready for review May 10, 2019 08:10
@swaterkamp swaterkamp requested a review from a team May 10, 2019 08:10
@swaterkamp swaterkamp changed the title Disable EditIcon while loading UserSettings Disable EditIcon while loading filters (also fix loading filters) May 10, 2019
@swaterkamp swaterkamp merged commit 178d0f6 into greenbone:gsa-8.0 May 10, 2019
@swaterkamp swaterkamp deleted the RaceCondSettings branch May 10, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants