Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reload timer for detail pages #1389

Merged
merged 4 commits into from
May 10, 2019
Merged

Fix reload timer for detail pages #1389

merged 4 commits into from
May 10, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented May 10, 2019

Checklist:

When clearing the timer the timer must be reset to undefined to be able
to be restarted later.
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #1389 into gsa-8.0 will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-8.0   #1389      +/-   ##
==========================================
- Coverage    36.15%   36.1%   -0.06%     
==========================================
  Files          960     960              
  Lines        21651   21683      +32     
  Branches      6017    6014       -3     
==========================================
  Hits          7828    7828              
- Misses       12486   12519      +33     
+ Partials      1337    1336       -1
Impacted Files Coverage Δ
gsa/src/web/entity/container.js 5% <0%> (-0.36%) ⬇️
gsa/src/web/pages/usersettings/usersettingspage.js 3.23% <0%> (-0.31%) ⬇️
gsa/src/web/pages/scanconfigs/editdialog.js 8.69% <0%> (-0.08%) ⬇️
gsa/src/web/pages/usersettings/dialog.js 30.76% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f17a72...37a1818. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review May 10, 2019 10:34
@bjoernricks bjoernricks requested a review from a team May 10, 2019 10:34
@swaterkamp swaterkamp merged commit 77e52eb into greenbone:gsa-8.0 May 10, 2019
@bjoernricks bjoernricks deleted the fix-reload-timer-for-detail-pages branch May 10, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants