Fix clearing timer #1396
Merged
Fix clearing timer #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Of course resetting the timer id to undefined must be done after clearing the timer.
sarahd93
approved these changes
May 13, 2019
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1396 +/- ##
========================================
Coverage 36.39% 36.39%
========================================
Files 960 960
Lines 21657 21657
Branches 6018 6018
========================================
Hits 7881 7881
Misses 12444 12444
Partials 1332 1332
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course resetting the timer id to undefined must be done after
clearing the timer.
Checklist: