Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix host links #1399

Merged
merged 3 commits into from
May 13, 2019
Merged

Fix host links #1399

merged 3 commits into from
May 13, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented May 13, 2019 •
edited
Loading

Checklist:

@bjoernricks
Don't set id for result hosts with empty id
bf83b5d 
If a result host doesn't have an id the id MUST BE set to undefined to
not render a link to the host asset details page.
@bjoernricks
Don't render links to host asset details page
6c0a946 
If the host doesn't have an id don't render the link to the host asset
details page.
@bjoernricks
Add changelog entry for host link fixes
453a9e0
@bjoernricks bjoernricks marked this pull request as ready for review May 13, 2019 14:24
@bjoernricks bjoernricks requested a review from a team May 13, 2019 14:24
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #1399 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1399      +/-   ##
===========================================
- Coverage    36.38%   36.38%   -0.01%     
===========================================
  Files          960      960              
  Lines        21658    21664       +6     
  Branches      5997     6003       +6     
===========================================
+ Hits          7881     7883       +2     
- Misses       12445    12449       +4     
  Partials      1332     1332
Impacted Files Coverage Δ
gsa/src/web/pages/results/row.js 7.4% <0%> (-0.6%) ⬇️
gsa/src/web/pages/results/detailspage.js 10.93% <0%> (-0.36%) ⬇️
gsa/src/gmp/models/result.js 96.22% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70fe54d...453a9e0. Read the comment docs.

@bjoernricks bjoernricks merged commit b235d40 into greenbone:gsa-8.0 May 13, 2019
@bjoernricks bjoernricks deleted the fix-host-links branch May 13, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahd93 sarahd93 sarahd93 approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @sarahd93