Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for severitylevelsgroup, radio and task trend #1413

Merged
merged 5 commits into from
May 20, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review May 17, 2019 10:27
@sarahd93 sarahd93 requested a review from a team May 17, 2019 10:27
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #1413 into gsa-8.0 will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1413      +/-   ##
===========================================
+ Coverage    36.82%   36.83%   +0.01%     
===========================================
  Files          961      960       -1     
  Lines        21737    21741       +4     
  Branches      6020     6017       -3     
===========================================
+ Hits          8004     8009       +5     
+ Misses       12410    12409       -1     
  Partials      1323     1323
Impacted Files Coverage Δ
gsa/src/gmp/http/transform/fastxml.js 20% <0%> (-80%) ⬇️
gsa/src/gmp/http/response.js 52.63% <0%> (-27.37%) ⬇️
gsa/src/gmp/http/transform/x2js.js 18.18% <0%> (-26.27%) ⬇️
gsa/src/gmp/models/filter/convert.js 100% <0%> (ø) ⬆️
gsa/src/gmp/http/rejection.js 100% <0%> (ø) ⬆️
gsa/src/gmp/models/testing.js 100% <0%> (ø) ⬆️
gsa/src/gmp/http/transform/xml.js
gsa/src/gmp/parser.js 99.14% <0%> (ø) ⬆️
gsa/src/web/utils/withComponentDefaults.js 100% <0%> (+25%) ⬆️
.../web/components/powerfilter/severitylevelsgroup.js 85.71% <0%> (+80.95%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188ed32...cab771d. Read the comment docs.

@swaterkamp swaterkamp merged commit a1fff14 into greenbone:gsa-8.0 May 20, 2019
@sarahd93 sarahd93 deleted the add_more_tests_gsa8 branch May 20, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants