Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for filter groups #1419

Merged
merged 10 commits into from
May 21, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review May 20, 2019 13:18
@sarahd93 sarahd93 requested a review from a team May 20, 2019 13:18
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #1419 into gsa-8.0 will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-8.0   #1419      +/-   ##
==========================================
+ Coverage    36.97%   37.1%   +0.12%     
==========================================
  Files          961     961              
  Lines        21741   21741              
  Branches      6045    6023      -22     
==========================================
+ Hits          8038    8066      +28     
+ Misses       12387   12366      -21     
+ Partials      1316    1309       -7
Impacted Files Coverage Δ
gsa/src/web/components/powerfilter/autofpgroup.js 100% <0%> (+50%) ⬆️
.../web/components/powerfilter/applyoverridesgroup.js 85.71% <0%> (+57.14%) ⬆️
gsa/src/web/components/powerfilter/minqodgroup.js 100% <0%> (+60%) ⬆️
...src/web/components/powerfilter/firstresultgroup.js 100% <0%> (+60%) ⬆️
.../web/components/powerfilter/resultsperpagegroup.js 100% <0%> (+60%) ⬆️
...rc/web/components/powerfilter/filterstringgroup.js 100% <0%> (+66.66%) ⬆️
gsa/src/web/components/powerfilter/sortbygroup.js 100% <0%> (+90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 627b80d...054a192. Read the comment docs.

@swaterkamp swaterkamp merged commit 1f7fa0f into greenbone:gsa-8.0 May 21, 2019
@sarahd93 sarahd93 deleted the filtergroup_tests_gsa8 branch May 21, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants