-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate new refs from NVTs #1424
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
=========================================
- Coverage 35.62% 35.6% -0.02%
=========================================
Files 982 980 -2
Lines 22042 21997 -45
Branches 6053 6058 +5
=========================================
- Hits 7852 7832 -20
+ Misses 12833 12808 -25
Partials 1357 1357
Continue to review full report at Codecov.
|
I tried the patch and it worked for me: I can see the references in all places I visited. |
type !== 'cert-bund' && | ||
type !== 'CERT-Bund' && | ||
type !== 'dfn-cert' && | ||
type !== 'DFN-CERT' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are both writings (lower and upper case) possible. We should really avoid such things. If we really need this, it would also be better to user type.toLowerCase() instead
Checklist: