Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate new refs from NVTs #1424

Merged
merged 6 commits into from
May 27, 2019
Merged

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp self-assigned this May 24, 2019
@swaterkamp swaterkamp marked this pull request as ready for review May 24, 2019 14:50
@swaterkamp swaterkamp requested a review from a team May 24, 2019 14:50
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #1424 into master will decrease coverage by 0.01%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1424      +/-   ##
=========================================
- Coverage   35.62%   35.6%   -0.02%     
=========================================
  Files         982     980       -2     
  Lines       22042   21997      -45     
  Branches     6053    6058       +5     
=========================================
- Hits         7852    7832      -20     
+ Misses      12833   12808      -25     
  Partials     1357    1357
Impacted Files Coverage Δ
gsa/src/web/components/link/certlink.js 100% <100%> (ø) ⬆️
gsa/src/gmp/models/nvt.js 98.66% <97.43%> (-1.34%) ⬇️
gsa/src/web/components/snackbar/snackbar.js
gsa/src/stories/snackbar.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee73e68...46e5dc9. Read the comment docs.

@janowagner
Copy link
Member

I tried the patch and it worked for me: I can see the references in all places I visited.

@swaterkamp swaterkamp merged commit 12b9f6b into greenbone:master May 27, 2019
type !== 'cert-bund' &&
type !== 'CERT-Bund' &&
type !== 'dfn-cert' &&
type !== 'DFN-CERT'
Copy link
Contributor

@bjoernricks bjoernricks May 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are both writings (lower and upper case) possible. We should really avoid such things. If we really need this, it would also be better to user type.toLowerCase() instead

@swaterkamp swaterkamp deleted the xrefs branch February 20, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants