Fix loading timezone and locale at login #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timezone and i18n are not found in the response.data but response.meta, so login variables have to be stitched together from both those fields. This solves several issues including non-workign user settings and the performance page.
swaterkamp
force-pushed
the
TimezoneLocaleAtLogin
branch
from
0fe0deb
to
5c0cdc2
Compare
sarahd93
approved these changes
May 27, 2019
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1426 +/- ##
==========================================
+ Coverage 37.1% 37.1% +<.01%
==========================================
Files 961 961
Lines 21741 21742 +1
Branches 6024 6047 +23
==========================================
+ Hits 8066 8067 +1
Misses 12365 12365
Partials 1310 1310
Continue to review full report at Codecov.
|
bjoernricks
reviewed
May 27, 2019
| this.version = elem.version; | ||
|
|
||
| const unixSeconds = parseInt(elem.session); | ||
| const {data = {}, meta = {}} = elem; |
There was a problem hiding this comment.
Hi the Login model should be reworked to get all necessary values as arguments to the constructor again and should not have to know anything about meta and data. The command must pass the arguments from meta and data to the model instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timezone and i18n are not found in the response.data but response.meta,
so login variables have to be stitched together from both those fields.
This solves several issues including non-workign user settings and the
performance page.
Checklist: