Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some FileFields #1430

Merged
merged 3 commits into from
May 29, 2019
Merged

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented May 28, 2019

If corresponding radio buttons are not checked, the FileFields belonging to them are disabled to prevent confusion.

Checklist:

@swaterkamp swaterkamp requested a review from sarahd93 May 28, 2019 15:11
@swaterkamp swaterkamp self-assigned this May 28, 2019
@swaterkamp swaterkamp marked this pull request as ready for review May 28, 2019 15:13
@swaterkamp swaterkamp requested a review from a team May 28, 2019 15:13
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #1430 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1430      +/-   ##
===========================================
- Coverage     37.1%   37.09%   -0.01%     
===========================================
  Files          961      961              
  Lines        21742    21744       +2     
  Branches      6047     6027      -20     
===========================================
  Hits          8067     8067              
- Misses       12365    12367       +2     
  Partials      1310     1310
Impacted Files Coverage Δ
gsa/src/web/pages/portlists/dialog.js 17.39% <ø> (ø) ⬆️
gsa/src/web/pages/targets/dialog.js 19.71% <0%> (-0.58%) ⬇️
gsa/src/web/pages/vulns/listpage.js 42.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b83b82...d1a2c29. Read the comment docs.

@swaterkamp swaterkamp merged commit 4909e7e into greenbone:gsa-8.0 May 29, 2019
@swaterkamp swaterkamp deleted the DisableFileFields branch May 29, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants