Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamic ref types for NVT model #1434

Merged
merged 5 commits into from
May 31, 2019
Merged

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp requested a review from sarahd93 May 31, 2019 10:20
@swaterkamp swaterkamp self-assigned this May 31, 2019
@swaterkamp swaterkamp marked this pull request as ready for review May 31, 2019 10:21
@swaterkamp swaterkamp requested a review from a team May 31, 2019 10:21
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #1434 into master will increase coverage by <.01%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   35.64%   35.64%   +<.01%     
==========================================
  Files         982      982              
  Lines       22050    22052       +2     
  Branches     6063     6063              
==========================================
+ Hits         7859     7861       +2     
  Misses      12834    12834              
  Partials     1357     1357
Impacted Files Coverage Δ
gsa/src/web/pages/nvts/references.js 10% <0%> (ø) ⬆️
gsa/src/gmp/models/nvt.js 98.75% <100%> (+0.08%) ⬆️
gsa/src/web/components/link/certlink.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b9f6b...36063d7. Read the comment docs.

@swaterkamp swaterkamp merged commit ed9af66 into greenbone:master May 31, 2019
@swaterkamp swaterkamp deleted the Xrefs branch May 31, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants