Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Notes and Overrides of Results #1446

Merged
merged 4 commits into from
Jun 20, 2019

Conversation

swaterkamp
Copy link
Member

Needs greenbone/gvmd#603 to work.

With this PR, notes and overrides are shown on results detailspages and an icon indicator is present in the rows on results listpage and report results lists.

Checklist:

@swaterkamp swaterkamp self-assigned this Jun 20, 2019
@swaterkamp swaterkamp marked this pull request as ready for review June 20, 2019 08:20
@swaterkamp swaterkamp requested a review from a team June 20, 2019 08:20
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #1446 into gsa-8.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1446      +/-   ##
===========================================
+ Coverage    37.22%   37.22%   +<.01%     
===========================================
  Files          962      962              
  Lines        21761    21763       +2     
  Branches      6042     6065      +23     
===========================================
+ Hits          8100     8102       +2     
  Misses       12355    12355              
  Partials      1306     1306
Impacted Files Coverage Δ
gsa/src/web/pages/notes/dialog.js 4.16% <ø> (ø) ⬆️
gsa/src/gmp/commands/results.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d945151...4cafcc2. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@swaterkamp swaterkamp merged commit d2f2657 into greenbone:gsa-8.0 Jun 20, 2019
@swaterkamp swaterkamp deleted the ResultsNotesOverrides branch June 20, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants