Added fields to filterdialog for results page. #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last pull request was closed by accident. updated Changelog to reference current pull request instead of last one.
Codecov Report
@@ Coverage Diff @@
## master #1472 +/- ##
==========================================
- Coverage 36.87% 36.79% -0.09%
==========================================
Files 992 996 +4
Lines 22240 22224 -16
Branches 6136 6121 -15
==========================================
- Hits 8201 8177 -24
+ Misses 12723 12722 -1
- Partials 1316 1325 +9
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Jul 11, 2019
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
bjoernricks
previously approved these changes
Jul 11, 2019
swaterkamp
approved these changes
Jul 11, 2019
bjoernricks
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added filter keywords owner, host, cvss base score, vulnerability and location to filter dialog on results page. Also added some sort fields, as well as tests for each of the new components.
Checklist: