Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added relationselector and severityvaluesgroup component #1477

Merged
merged 12 commits into from
Jul 16, 2019

Conversation

saberlynx
Copy link
Contributor

  • added a component "RelationSelector" to select between '=', '<' and '>'. All it does is select relation.
  • added a component "SeverityValuesGroup" replacing CvssBaseGroup (it is now more general) that has "RelationSelector" as child, enabling user to do eg. "cvss_base>3"

Checklist:

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #1477 into master will increase coverage by 0.03%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
+ Coverage   36.89%   36.93%   +0.03%     
==========================================
  Files         994      995       +1     
  Lines       22256    22271      +15     
  Branches     6140     6139       -1     
==========================================
+ Hits         8211     8225      +14     
- Misses      12729    12730       +1     
  Partials     1316     1316
Impacted Files Coverage Δ
gsa/src/web/pages/results/filterdialog.js 50% <ø> (ø) ⬆️
...src/web/components/powerfilter/relationselector.js 100% <100%> (ø)
.../web/components/powerfilter/severityvaluesgroup.js 94.11% <94.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45de398...0f80585. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review July 16, 2019 10:52
saberlynx and others added 5 commits July 16, 2019 14:01
made text translatable.

Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
made text translatable.

Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bjoernricks bjoernricks merged commit 73e25b1 into greenbone:master Jul 16, 2019
@saberlynx saberlynx deleted the relationSelector branch July 17, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants