-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu update #1481
Menu update #1481
Conversation
This is needed in order to get the stack context of the Header above the dark menu bar.
It keeps breaking for some reason. Datepicker hasn't been touched in this PR.
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
- Coverage 36.93% 36.93% -0.01%
==========================================
Files 995 995
Lines 22271 22261 -10
Branches 6139 6138 -1
==========================================
- Hits 8225 8221 -4
+ Misses 12730 12725 -5
+ Partials 1316 1315 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please still use isLoggedOut as variable name to indicate that the variable contains a boolean.
); | ||
} | ||
} | ||
const Titlebar = ({gmp, loggedIn}) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const Titlebar = ({gmp, loggedIn}) => ( | |
const Titlebar = ({gmp, isLoggedIn}) => ( |
Checklist: