Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu update #1481

Merged
merged 13 commits into from
Jul 16, 2019
Merged

Menu update #1481

merged 13 commits into from
Jul 16, 2019

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Jul 16, 2019

  • Restructure menu categories
  • add animations
  • add new Logout icon
  • add new UserMenu to top right for linking to usersettings, logout and show user information
  • remove unused UserLink

Checklist:

@swaterkamp swaterkamp marked this pull request as ready for review July 16, 2019 13:23
@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #1481 into master will decrease coverage by <.01%.
The diff coverage is 48.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
- Coverage   36.93%   36.93%   -0.01%     
==========================================
  Files         995      995              
  Lines       22271    22261      -10     
  Branches     6139     6138       -1     
==========================================
- Hits         8225     8221       -4     
+ Misses      12730    12725       -5     
+ Partials     1316     1315       -1
Impacted Files Coverage Δ
gsa/src/web/pages/page.js 13.63% <ø> (ø) ⬆️
gsa/src/web/components/menu/menu.js 31.81% <ø> (ø) ⬆️
gsa/src/web/components/bar/menubar.js 7.6% <0%> (+0.08%) ⬆️
gsa/src/web/components/icon/logouticon.js 100% <100%> (ø)
gsa/src/web/components/menu/usermenu.js 100% <100%> (ø)
gsa/src/web/components/bar/titlebar.js 100% <100%> (+21.73%) ⬆️
gsa/src/web/components/form/selectelements.js 92.1% <0%> (-1.32%) ⬇️
gsa/src/web/pages/results/filterdialog.js 50% <0%> (ø) ⬆️
.../web/components/powerfilter/severityvaluesgroup.js
...src/web/components/powerfilter/relationselector.js
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e25b1...3c2700c. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please still use isLoggedOut as variable name to indicate that the variable contains a boolean.

gsa/src/web/components/bar/titlebar.js Show resolved Hide resolved
gsa/src/web/components/bar/titlebar.js Show resolved Hide resolved
gsa/src/web/components/bar/titlebar.js Show resolved Hide resolved
);
}
}
const Titlebar = ({gmp, loggedIn}) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const Titlebar = ({gmp, loggedIn}) => (
const Titlebar = ({gmp, isLoggedIn}) => (

@bjoernricks bjoernricks self-requested a review July 16, 2019 14:29
bjoernricks
bjoernricks previously approved these changes Jul 16, 2019
@swaterkamp swaterkamp merged commit a120c2e into greenbone:master Jul 16, 2019
@swaterkamp swaterkamp deleted the MenuUpdate branch July 16, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants