Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added BooleanFilterGroup and changed notes filter dialog #1493

Merged
merged 7 commits into from
Jul 23, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Jul 19, 2019

Checklist:

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #1493 into master will decrease coverage by 0.04%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1493      +/-   ##
==========================================
- Coverage   37.08%   37.04%   -0.05%     
==========================================
  Files         998      999       +1     
  Lines       22273    22281       +8     
  Branches     6118     6121       +3     
==========================================
- Hits         8261     8253       -8     
- Misses      12699    12714      +15     
- Partials     1313     1314       +1
Impacted Files Coverage Δ
gsa/src/web/pages/reports/filterdialog.js 33.33% <ø> (ø) ⬆️
gsa/src/web/pages/reports/detailsfilterdialog.js 20% <ø> (ø) ⬆️
gsa/src/web/pages/results/filterdialog.js 50% <ø> (ø) ⬆️
gsa/src/web/pages/tasks/filterdialog.js 33.33% <ø> (ø) ⬆️
...c/web/components/powerfilter/booleanfiltergroup.js 100% <100%> (ø)
gsa/src/web/pages/notes/filterdialog.js 50% <40%> (-50%) ⬇️
gsa/src/gmp/models/event.js 5.94% <0%> (-7.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4020547...0ded11f. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review July 19, 2019 12:04
@bjoernricks bjoernricks merged commit b49b621 into greenbone:master Jul 23, 2019
@saberlynx saberlynx deleted the notesFilter branch July 23, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants