Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select components fixes #1504

Merged
merged 14 commits into from
Jul 23, 2019
Merged

Select components fixes #1504

merged 14 commits into from
Jul 23, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jul 23, 2019 •
edited
Loading

Checklist:

@bjoernricks
Update downshift to 3.2.10
2dcc3c9
@bjoernricks
Update (Multi)Select to Downshift API changes
89291fe 
* getButtonProps => getToggleButtonProps
* event.preventDefault() => event.preventDownshiftDefault = true
* add getMenuProps
* pass additional props to prop getters
* use current react ref api
@bjoernricks
Use new react ref API for Menu component
1945c1a 
Update Menu to use current ref API.
@bjoernricks
Forward ref to inner component of Menu
7648c96 
Allow to forward the ref at the Menu component to the inner DOM element.
@bjoernricks
Add missing colon at css rule
0d12b18
@bjoernricks
Use the event object directly to cancel downshift event handling
8dbd18c 
Use event.preventDownshiftDefault instead of
event.native.preventDownshiftDefault. The native objects seems to be not
available in tests.
@bjoernricks
Update select components for selecting an item
5a5703f 
Move selecting an item into the click handlers. It isn't necessary to
use the onMouseDown event anymore.
@bjoernricks
Add a data-testid for the search input of select
f97b21f 
Allow for easier querying the search input field in tests.
@bjoernricks
Update snapshot tests using select components
3d28c3e
@bjoernricks
Update Menu tests to use new ref react api
fbff0c6
@bjoernricks
Unify select component test helper functions
e301719 
Use the same functions in all tests and update getInputBox to use new
select-search-input test id.
@bjoernricks
Expect two select items to be rendered
3dfd6bd
@bjoernricks
Add changelog entry
eb2b2ef
@bjoernricks bjoernricks marked this pull request as ready for review July 23, 2019 11:47
@codecov
Copy link

codecov bot commented Jul 23, 2019 •
edited
Loading

Codecov Report

Merging #1504 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
+ Coverage   37.11%   37.12%   +0.01%     
==========================================
  Files        1000     1000              
  Lines       22306    22312       +6     
  Branches     6136     6136              
==========================================
+ Hits         8278     8284       +6     
+ Misses      12715    12714       -1     
- Partials     1313     1314       +1
Impacted Files Coverage Δ
gsa/src/web/components/form/select.js 92.53% <100%> (+1.76%) ⬆️
gsa/src/web/components/form/selectelements.js 89.87% <100%> (-2.34%) ⬇️
gsa/src/web/components/form/multiselect.js 97.29% <100%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b553975...eb2b2ef. Read the comment docs.

@bjoernricks bjoernricks merged commit 7dc8a13 into greenbone:master Jul 23, 2019
@bjoernricks bjoernricks deleted the select-fixes branch July 23, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @swaterkamp