Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't logout user at login page #1508

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Don't logout user at login page #1508

merged 3 commits into from
Jul 24, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jul 24, 2019

Redirect to main page if the user is already logged in when visiting the
login page instead of clearing his token.

Checklist:

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #1508 into gsa-8.0 will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1508      +/-   ##
===========================================
+ Coverage    37.42%   37.42%   +<.01%     
===========================================
  Files          964      964              
  Lines        21828    21830       +2     
  Branches      6102     6083      -19     
===========================================
+ Hits          8169     8170       +1     
- Misses       12359    12360       +1     
  Partials      1300     1300
Impacted Files Coverage Δ
gsa/src/web/pages/login/loginpage.js 89.85% <75%> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ab2c47...acd17a8. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review July 24, 2019 08:17
@bjoernricks bjoernricks requested a review from a team July 24, 2019 08:17
swaterkamp
swaterkamp previously approved these changes Jul 24, 2019
@bjoernricks bjoernricks changed the title Don't logout use at login page Don't logout user at login page Jul 24, 2019
Redirect to main page if the user is already logged in when visiting the
login page instead of clearing his token.
@swaterkamp swaterkamp merged commit 9eec36f into greenbone:gsa-8.0 Jul 24, 2019
@bjoernricks bjoernricks deleted the login-not-logout branch July 24, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants