Ical date recurrence fix #1539
Merged
Ical date recurrence fix #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ical times are very dangerous to use. Use moment.js to create a current datetime object and compare the unix timestamps (which is always in UTC) for getting the due date.
Don't log warning if ical.js raised error due to finding same dates which can happen due to 30 and last day are contained in the recurrence rule.
swaterkamp
previously approved these changes
Aug 5, 2019
swaterkamp
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix calculating the next date of a schedule ical event. ical times are evil 👿
Checklist: