Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fast xml parser by default #1556

Merged
merged 5 commits into from
Aug 8, 2019
Merged

Use fast xml parser by default #1556

merged 5 commits into from
Aug 8, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Aug 8, 2019 •
edited
Loading

Checklist:

@bjoernricks
Use fast-xml for transforming gmp responses by default
dd78020 
With the next release we should use the much faster API by default.
@bjoernricks
No need to set special transform for report anymore
dbf8cea 
fast xml transform is the default now.
@bjoernricks
Remove x2js transform module
8806e22 
The module is unused now.
@bjoernricks
Drop x2js as dependency
e888279 
We are not using x2js anymore.
@bjoernricks
Add changelog entry
25e92ea
@bjoernricks bjoernricks marked this pull request as ready for review August 8, 2019 10:23
@codecov
Copy link

codecov bot commented Aug 8, 2019 •
edited
Loading

Codecov Report

Merging #1556 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1556      +/-   ##
=========================================
- Coverage    36.5%   36.5%   -0.01%     
=========================================
  Files        1032    1031       -1     
  Lines       23805   23796       -9     
  Branches     6572    6548      -24     
=========================================
- Hits         8690    8686       -4     
+ Misses      13727   13723       -4     
+ Partials     1388    1387       -1
Impacted Files Coverage Δ
gsa/src/gmp/commands/reports.js 21.87% <ø> (ø) ⬆️
gsa/src/gmp/http/gmp.js 62.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34cf09d...25e92ea. Read the comment docs.

@swaterkamp swaterkamp merged commit ac781a8 into greenbone:master Aug 8, 2019
@bjoernricks bjoernricks deleted the use-fast-xml-parser-by-default branch August 8, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @swaterkamp