Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global styles #1557

Merged
merged 10 commits into from
Aug 8, 2019
Merged

Global styles #1557

merged 10 commits into from
Aug 8, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Aug 8, 2019 •
edited
Loading

Checklist:

@bjoernricks
Add a new component for rendering global styles
6fe061d
@bjoernricks
Add default font size to the theme
ed85658
@bjoernricks
Use new GlobalStyles component
c78e89b 
Replace rendering of global styles via glamor with a styled component.
@bjoernricks
Drop unused globalcss helper
7a4021f 
We are using the GlobalStyles component instead now.
@bjoernricks bjoernricks marked this pull request as ready for review August 8, 2019 13:23
@bjoernricks
Use styled-component for LineChart css
6741b57 
With this change glamor is only used for the Axis component.
@bjoernricks
Add an snapshot test for GlobalStyles
ade981f 
Currently this test may be a bit flacky. It will fail e.g. if glamor is
removed or the version of styled-component is changed. If it fails to
often it should be removed.
@bjoernricks
Update unrelated datepicker snapshot again
d8b2cd5
@bjoernricks
Add changelog entry
67e20ef
@codecov
Copy link

codecov bot commented Aug 8, 2019 •
edited
Loading

Codecov Report

Merging #1557 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
+ Coverage    36.5%   36.51%   +0.01%     
==========================================
  Files        1031     1031              
  Lines       23796    23792       -4     
  Branches     6571     6570       -1     
==========================================
+ Hits         8686     8687       +1     
+ Misses      13723    13719       -4     
+ Partials     1387     1386       -1
Impacted Files Coverage Δ
gsa/src/web/app.js 0% <ø> (ø) ⬆️
gsa/src/web/utils/theme.js 100% <ø> (ø) ⬆️
gsa/src/web/components/layout/globalstyles.js 100% <100%> (ø)
gsa/src/web/components/chart/line.js 12.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f3dca1...3f9c868. Read the comment docs.

swaterkamp
swaterkamp reviewed Aug 8, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
swaterkamp
swaterkamp requested changes Aug 8, 2019
View reviewed changes
Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a small typo in the Changelog. Other than that this PR looks good.

swaterkamp and others added 2 commits August 8, 2019 16:30
@swaterkamp
Merge branch 'master' into global-styles
6f41d61
@bjoernricks @swaterkamp
Update CHANGELOG.md
3f9c868 
Co-Authored-By: Steffen Waterkamp <32056637+swaterkamp@users.noreply.github.com>
@bjoernricks bjoernricks merged commit 2b30d51 into greenbone:master Aug 8, 2019
@bjoernricks bjoernricks deleted the global-styles branch August 8, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @swaterkamp