Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying only usable report formats at report download #1565

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Fix displaying only usable report formats at report download #1565

merged 2 commits into from
Aug 13, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Aug 13, 2019 •
edited
Loading

Checklist:

@bjoernricks bjoernricks marked this pull request as ready for review August 13, 2019 09:45
@bjoernricks bjoernricks requested a review from a team August 13, 2019 09:45
@codecov
Copy link

codecov bot commented Aug 13, 2019 •
edited
Loading

Codecov Report

Merging #1565 into gsa-8.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           gsa-8.0    #1565   +/-   ##
========================================
  Coverage    37.52%   37.52%           
========================================
  Files          965      965           
  Lines        21967    21967           
  Branches      6138     6117   -21     
========================================
  Hits          8243     8243           
  Misses       12414    12414           
  Partials      1310     1310
Impacted Files Coverage Δ
gsa/src/web/pages/reports/detailspage.js 3.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8580c8...82b1b08. Read the comment docs.

@bjoernricks bjoernricks merged commit 969873a into greenbone:gsa-8.0 Aug 13, 2019
@bjoernricks bjoernricks deleted the list-only-usable-report-formats branch August 13, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahd93 sarahd93 sarahd93 approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @sarahd93