Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tooltips for settings that cant be edited once task has been run #1568

Merged
merged 3 commits into from
Aug 14, 2019
Merged

added tooltips for settings that cant be edited once task has been run #1568

merged 3 commits into from
Aug 14, 2019

Conversation

saberlynx
Copy link
Contributor

Checklist:

@saberlynx saberlynx changed the title dded tooltips for settings that cant be edited once task has been run added tooltips for settings that cant be edited once task has been run Aug 14, 2019
@codecov
Copy link

codecov bot commented Aug 14, 2019 •
edited
Loading

Codecov Report

Merging #1568 into gsa-8.0 will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-8.0   #1568      +/-   ##
==========================================
- Coverage    37.51%   37.5%   -0.02%     
==========================================
  Files          965     965              
  Lines        21970   21976       +6     
  Branches      6117    6123       +6     
==========================================
  Hits          8243    8243              
- Misses       12417   12423       +6     
  Partials      1310    1310
Impacted Files Coverage Δ
gsa/src/web/pages/tasks/dialog.js 7.89% <0%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e1b8a...0aad4ec. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review August 14, 2019 07:37
bjoernricks
bjoernricks suggested changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry?

@saberlynx saberlynx requested a review from a team August 14, 2019 08:04
bjoernricks
bjoernricks approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjoernricks bjoernricks merged commit db0798b into greenbone:gsa-8.0 Aug 14, 2019
@saberlynx saberlynx deleted the task-nonalterable branch August 28, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saberlynx @bjoernricks