Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse scanconfig edit dialogs for policies and add tests for san config edit dialogs #1573

Merged

Conversation

sarahd93
Copy link
Contributor

Checklist:

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #1573 into master will increase coverage by 1.39%.
The diff coverage is 65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1573      +/-   ##
==========================================
+ Coverage   36.44%   37.83%   +1.39%     
==========================================
  Files        1045     1042       -3     
  Lines       23990    23795     -195     
  Branches     6592     6542      -50     
==========================================
+ Hits         8744     9004     +260     
+ Misses      13844    13443     -401     
+ Partials     1402     1348      -54
Impacted Files Coverage Δ
gsa/src/web/pages/scanconfigs/trend.js 85.71% <ø> (+57.14%) ⬆️
...rc/web/pages/scanconfigs/editconfigfamilydialog.js 91.66% <ø> (+85%) ⬆️
gsa/src/web/pages/scanconfigs/component.js 0.59% <ø> (ø) ⬆️
.../src/web/pages/scanconfigs/editnvtdetailsdialog.js 86.66% <ø> (+83.33%) ⬆️
gsa/src/web/pages/policies/component.js 1.27% <0%> (-0.01%) ⬇️
gsa/src/web/pages/scanconfigs/editdialog.js 94.26% <100%> (+85.49%) ⬆️
gsa/src/web/utils/severity.js 74.32% <0%> (+1.35%) ⬆️
gsa/src/web/components/table/table.js 90.9% <0%> (+9.09%) ⬆️
gsa/src/web/components/folding/folding.js 39.53% <0%> (+26.74%) ⬆️
gsa/src/web/components/section/header.js 84.61% <0%> (+38.46%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09f1f9...fd6705c. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review August 16, 2019 11:19
Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the policy edit dialogs from the CMakeLists

gsa/src/web/pages/policies/component.js Outdated Show resolved Hide resolved
gsa/src/web/pages/scanconfigs/editconfigfamilydialog.js Outdated Show resolved Hide resolved
gsa/src/web/pages/policies/component.js Outdated Show resolved Hide resolved
@sarahd93 sarahd93 force-pushed the clean_up_explicit_compliance_master branch from c88c97e to 078c735 Compare August 16, 2019 13:47
@sarahd93 sarahd93 force-pushed the clean_up_explicit_compliance_master branch from 078c735 to 3a12e31 Compare August 16, 2019 14:50
@swaterkamp swaterkamp self-requested a review August 20, 2019 15:01
@sarahd93 sarahd93 merged commit c592887 into greenbone:master Aug 22, 2019
@sarahd93 sarahd93 deleted the clean_up_explicit_compliance_master branch August 22, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants