Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger alert button disabled in report details page when no permission #1574

Merged
merged 5 commits into from
Aug 22, 2019
Merged

trigger alert button disabled in report details page when no permission #1574

merged 5 commits into from
Aug 22, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Aug 19, 2019 •
edited
Loading

Checklist:

@codecov
Copy link

codecov bot commented Aug 19, 2019 •
edited
Loading

Codecov Report

Merging #1574 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-8.0   #1574      +/-   ##
==========================================
- Coverage     37.5%   37.5%   -0.01%     
==========================================
  Files          965     965              
  Lines        21977   21980       +3     
  Branches      6144    6125      -19     
==========================================
  Hits          8243    8243              
- Misses       12424   12427       +3     
  Partials      1310    1310
Impacted Files Coverage Δ
gsa/src/web/pages/reports/alertactions.js 6.55% <0%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7d34c...fc18c6b. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review August 19, 2019 10:20
@saberlynx saberlynx requested review from a team and sarahd93 August 19, 2019 10:20
swaterkamp
swaterkamp requested changes Aug 20, 2019
View reviewed changes
Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use withCapabilities instead of calling the gmp.user command directly.

swaterkamp and others added 2 commits August 22, 2019 16:33
@swaterkamp
Merge branch 'gsa-8.0' into no-trigger-alert
596bd80
@saberlynx @swaterkamp
Update gsa/src/web/pages/reports/alertactions.js
fc18c6b 
Co-Authored-By: Steffen Waterkamp <32056637+swaterkamp@users.noreply.github.com>
@swaterkamp swaterkamp merged commit b04a7a9 into greenbone:gsa-8.0 Aug 22, 2019
@saberlynx saberlynx deleted the no-trigger-alert branch August 28, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

@bjoernricks bjoernricks Awaiting requested review from bjoernricks

@sarahd93 sarahd93 Awaiting requested review from sarahd93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saberlynx @swaterkamp