Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added loading indicator to edit config dialog #1579

Merged
merged 3 commits into from
Aug 26, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Aug 26, 2019

Adding loading indicator to spin for 500ms before dialog content is rendered.

Checklist:

@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #1579 into gsa-8.0 will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1579      +/-   ##
===========================================
- Coverage     37.5%   37.48%   -0.02%     
===========================================
  Files          965      965              
  Lines        21980    21988       +8     
  Branches      6125     6126       +1     
===========================================
  Hits          8243     8243              
- Misses       12427    12434       +7     
- Partials      1310     1311       +1
Impacted Files Coverage Δ
gsa/src/web/pages/scanconfigs/editdialog.js 8.19% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04a7a9...4e1afee. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review August 26, 2019 12:43
@saberlynx saberlynx requested a review from a team August 26, 2019 12:43
@bjoernricks bjoernricks merged commit 671641f into greenbone:gsa-8.0 Aug 26, 2019
@saberlynx saberlynx deleted the scan-config-loading branch August 28, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants