Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced savedialogcontent class with hooks #1602

Merged
merged 2 commits into from
Sep 3, 2019

Conversation

saberlynx
Copy link
Contributor

Checklist:

@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #1602 into master will increase coverage by <.01%.
The diff coverage is 70.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1602      +/-   ##
=========================================
+ Coverage   39.59%   39.6%   +<.01%     
=========================================
  Files        1044    1044              
  Lines       23902   23896       -6     
  Branches     6590    6590              
=========================================
- Hits         9465    9464       -1     
+ Misses      13128   13123       -5     
  Partials     1309    1309
Impacted Files Coverage Δ
gsa/src/web/components/dialog/savedialog.js 73.68% <70.37%> (+7.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b51bd8...a68b22a. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review September 2, 2019 14:22
@bjoernricks bjoernricks merged commit 0dcf7ec into greenbone:master Sep 3, 2019
@saberlynx saberlynx deleted the refactor-save-dialog branch October 2, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants