Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading indication for content composers #1613

Merged
merged 4 commits into from
Sep 5, 2019
Merged

Loading indication for content composers #1613

merged 4 commits into from
Sep 5, 2019

Commits on Sep 5, 2019

  1. TwoButtonFooter: Disable Cancel when OK is loading

    @swaterkamp
    swaterkamp committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    c0f9107 View commit details
    Browse the repository at this point in the history

  2. Return Promises from handleReportDownload() and handleTriggerAlert() 

    This will correctly show a loading indicator in the dialog OK button
    @swaterkamp
    swaterkamp committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    7de2b42 View commit details
    Browse the repository at this point in the history

  3. Update Changelog

    @swaterkamp
    swaterkamp committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    611a2cd View commit details
    Browse the repository at this point in the history

  4. Update tests for TwoButtonFooter

    @swaterkamp
    swaterkamp committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    a62a2fd View commit details
    Browse the repository at this point in the history