Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for tables and listpages for policies and audits #1614

Merged
merged 8 commits into from
Sep 9, 2019

Conversation

sarahd93
Copy link
Contributor

@sarahd93 sarahd93 commented Sep 5, 2019

Checklist:

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #1614 into master will increase coverage by 1.51%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1614      +/-   ##
==========================================
+ Coverage    40.4%   41.91%   +1.51%     
==========================================
  Files        1044     1044              
  Lines       23928    23928              
  Branches     6610     6634      +24     
==========================================
+ Hits         9668    10030     +362     
+ Misses      12964    12652     -312     
+ Partials     1296     1246      -50
Impacted Files Coverage Δ
gsa/src/web/entities/withEntitiesContainer.js 95% <ø> (+60%) ⬆️
gsa/src/web/pages/audits/listpage.js 92.3% <100%> (+53.84%) ⬆️
gsa/src/web/pages/policies/listpage.js 100% <100%> (+63.63%) ⬆️
gsa/src/web/utils/render.js 20.61% <0%> (+0.61%) ⬆️
gsa/src/web/pages/audits/details.js 61.19% <0%> (+1.49%) ⬆️
gsa/src/web/pages/audits/row.js 81.25% <0%> (+3.12%) ⬆️
gsa/src/web/components/icon/exporticon.js 81.81% <0%> (+9.09%) ⬆️
gsa/src/web/components/icon/trashicon.js 80% <0%> (+10%) ⬆️
gsa/src/web/entities/header.js 60.71% <0%> (+14.28%) ⬆️
gsa/src/gmp/collection/collectioncounts.js 52.17% <0%> (+17.39%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c15c1c...3672f58. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review September 5, 2019 14:29
@swaterkamp swaterkamp self-requested a review September 9, 2019 11:15
Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at my comments and also test the missing close/cancel button in the dialog. Other than that it looks good to me. Thanks for putting in the effort for this PR and all the other testing PRs!

Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sarahd93 sarahd93 merged commit cf79a4a into greenbone:master Sep 9, 2019
@sarahd93 sarahd93 deleted the compliance_tests_master branch September 9, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants