-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for tables and listpages for policies and audits #1614
Conversation
8960100
to
275907c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
+ Coverage 40.4% 41.91% +1.51%
==========================================
Files 1044 1044
Lines 23928 23928
Branches 6610 6634 +24
==========================================
+ Hits 9668 10030 +362
+ Misses 12964 12652 -312
+ Partials 1296 1246 -50
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at my comments and also test the missing close/cancel button in the dialog. Other than that it looks good to me. Thanks for putting in the effort for this PR and all the other testing PRs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Checklist: