Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statusbar content can be more than 100 percent #1621

Merged
merged 4 commits into from
Sep 10, 2019

Conversation

sarahd93
Copy link
Contributor

@sarahd93 sarahd93 commented Sep 9, 2019

Checklist:

@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #1621 into gsa-8.0 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1621      +/-   ##
===========================================
+ Coverage    37.46%   37.47%   +0.01%     
===========================================
  Files          966      966              
  Lines        22089    22093       +4     
  Branches      6208     6231      +23     
===========================================
+ Hits          8276     8280       +4     
  Misses       12489    12489              
  Partials      1324     1324
Impacted Files Coverage Δ
gsa/src/web/utils/theme.js 100% <ø> (ø) ⬆️
gsa/src/web/components/bar/statusbar.js 87.5% <100%> (+0.32%) ⬆️
gsa/src/web/components/bar/progressbar.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1e58e...e46f5d9. Read the comment docs.

Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check components/bar/progressbar.js instead of fixing the statusbar? It has some lines of code dealing with this issue already and it should not appear even without your changes. Maybe we are checking the values at the wrong place (within a styled-components function in this case, ll. 80-85).
If your changes are indeed correct, we should find out what progressbar is doing with the information and if we could remove the if's there.

bjoernricks
bjoernricks previously approved these changes Sep 10, 2019
@sarahd93 sarahd93 marked this pull request as ready for review September 10, 2019 08:52
@sarahd93 sarahd93 requested a review from a team September 10, 2019 08:52
@swaterkamp swaterkamp self-requested a review September 10, 2019 09:56
@sarahd93 sarahd93 merged commit 6d33596 into greenbone:gsa-8.0 Sep 10, 2019
@sarahd93 sarahd93 deleted the statusbar_gsa8 branch September 10, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants