-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added change method to Field and TextArea component, removed withChangeHandler #1625
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
- Coverage 41.96% 41.93% -0.03%
==========================================
Files 1045 1044 -1
Lines 23968 23955 -13
Branches 6615 6635 +20
==========================================
- Hits 10058 10046 -12
+ Misses 12664 12663 -1
Partials 1246 1246
Continue to review full report at Codecov.
|
5ddcb76
to
3626b7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🎉 🎈
To fix the build error https://github.com/greenbone/gsa/blob/master/gsa/CMakeLists.txt#L278 need to be removed. |
f040da4
to
78826d0
Compare
There should now be no form components using withChangeHandler so I took the liberty to remove it and add in its export (noop_convert) manually in places that do use it. I can drop this removal if necessary.
Checklist: