Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added change method to Field and TextArea component, removed withChangeHandler #1625

Merged
merged 6 commits into from
Sep 12, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Sep 11, 2019

There should now be no form components using withChangeHandler so I took the liberty to remove it and add in its export (noop_convert) manually in places that do use it. I can drop this removal if necessary.
Checklist:

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #1625 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1625      +/-   ##
==========================================
- Coverage   41.96%   41.93%   -0.03%     
==========================================
  Files        1045     1044       -1     
  Lines       23968    23955      -13     
  Branches     6615     6635      +20     
==========================================
- Hits        10058    10046      -12     
+ Misses      12664    12663       -1     
  Partials     1246     1246
Impacted Files Coverage Δ
gsa/src/web/components/form/withClickHandler.js 100% <100%> (ø) ⬆️
gsa/src/web/pages/nvts/nvtpreference.js 72.72% <100%> (+0.85%) ⬆️
gsa/src/web/components/form/textarea.js 100% <100%> (ø) ⬆️
gsa/src/web/components/form/field.js 100% <100%> (ø) ⬆️
gsa/src/web/pages/scanconfigs/editdialog.js 94.65% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db6581...5b7e0d4. Read the comment docs.

@saberlynx saberlynx changed the title Added change method to Field component and refactored DatePicker into function Added change method to Field and TextArea component, refactored DatePicker into function Sep 11, 2019
@saberlynx saberlynx changed the title Added change method to Field and TextArea component, refactored DatePicker into function Added change method to Field and TextArea component, removed withChangeHandler Sep 11, 2019
bjoernricks
bjoernricks previously approved these changes Sep 11, 2019
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🎉 🎈

@bjoernricks
Copy link
Contributor

To fix the build error https://github.com/greenbone/gsa/blob/master/gsa/CMakeLists.txt#L278 need to be removed.

@bjoernricks bjoernricks merged commit 4042e28 into greenbone:master Sep 12, 2019
@saberlynx saberlynx deleted the form-refactor branch September 19, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants