Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OSP Sensor type to GSA #1646

Merged
merged 8 commits into from
Sep 30, 2019
Merged

Add OSP Sensor type to GSA #1646

merged 8 commits into from
Sep 30, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Sep 26, 2019 •
edited
Loading

Checklist:
Changes:

  • Added OSP Sensor Scanner Type. It is now Type 5, and updated scannerTypeName function.
  • Updated tests, to test for this new name and cloneability/writeability
  • Add OSP Sensor Type to Scanner Dialog. credential_id = '' if a scanner is of this type.
  • OSP Sensor Type is now in Task Dialog, with the same options as GMP Scanners
  • Made OSP Sensors selectable on performance page.
  • Modified validator of credential_id to allow empty string.

@saberlynx saberlynx changed the title Added OSP Sensor type to GSA Add OSP Sensor type to GSA Sep 26, 2019
@bjoernricks
Copy link
Contributor

It already works as expected 👍

@saberlynx saberlynx added the work in progress This pull request should not be merged yet, more commits are expected label Sep 27, 2019
@saberlynx saberlynx marked this pull request as ready for review September 27, 2019 13:27
bjoernricks
bjoernricks previously approved these changes Sep 27, 2019
View reviewed changes
gsa/src/web/pages/performance/performancepage.js
@@ -162,7 +162,9 @@ const Selector = withClickHandler()(styled.span`
}}
`);

const SLAVE_SCANNER_FILTER = Filter.fromString('type=' + GMP_SCANNER_TYPE);
const SLAVE_SCANNER_FILTER = Filter.fromString(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could rename this variable in another PR. Something like SENSOR_SCANNERS_FILTER

gsa/src/web/pages/scanners/dialog.js Show resolved Hide resolved
@saberlynx saberlynx removed the work in progress This pull request should not be merged yet, more commits are expected label Sep 30, 2019
@bjoernricks bjoernricks merged commit 8da58d8 into greenbone:master Sep 30, 2019
@saberlynx saberlynx deleted the scanner-type-add branch October 2, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

@timopollmeier timopollmeier Awaiting requested review from timopollmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saberlynx @bjoernricks