Fix report cves #1673

bjoernricks · 2019-10-08T14:43:04Z

Checklist:

Tests
CHANGELOG Entry

When creating a ReportCve instance ensure that the used variables are always defined.

Use App.fromElement for parsing an App from a Report. Update properties of App to use consistent naming.

Use consistent naming for high results.

Use fromElement to parse a Report Host model.

Move initialization of values to the constructor and use camel case for hosts by ip property.

Init hosts in constructor. Use camel case for host by id property. Rename addSeverity to setSeverity and use new parser functions.

Use new functions for parsing. Init hosts in constructor. Use camel case for host by ip information. Update setSeverity method.

Report TLS Certificates are a very special "model". It acts very differently to the normal models because it is not generated from an xml response element. It's data is collected from several host information elements.

Update the setProperties function to allow overriding properties of the object.

Use the fromElement static function to create new models to spot possible side effects from running the parsing code.

Fix setSeverity method or Port by allowing to override all parsed properties of the Model. The severity prop was parsed from the passed element and therefore has been freezed.

Use ReportHosts.fromElement method to parse hosts and add test for parsing an empty hosts list.

Use ReportPort.fromElement method to parse ports of a report and add tests for parsing these ports.

Use fromElement to parse vulns from a report and add tests.

Use ReportApp fromElement to parse new app models and add tests for parseApp.

Use ReportOperatingSystem fromElement method and add tests.

Add fromElement and parseElement methods to ReportTlsCertificate model. Use constructor only to init the ports property.

Put the parsed port into the array of ports instead of the original one.

Use new fromElement method and add tests.

Don't parse report vulnerabilities of a report anymore. Remove unused sort functions for reports vulnerabilities.

Drop the unused report vulnerability parsing code.

Report model parsing updates

Info responses are again special because they return e.g. <get_info_response><info><nvt>. Therefore the nvt model supports parsing from a nvt sub element too.

Simplify parsing nvt references by adding generic parsing functions.

The nvts got changed to collect all references in a separate refs element a while ago. The report data parsing code wasn't updated accordingly.

Copy name from the parsed nvt to the Report Cve model.

The cve page doesn't list each distinct cve. Instead it groups the cves found in a nvts. Therefore is more a list of cves per nvt instead of a list of cves. The severity also doesn't display the severity of the cves instead it displayes the severity of the result which is indeed the highest severity of found cves.

swaterkamp · 2019-10-08T15:15:25Z

gsa/src/web/pages/reports/cvestable.js

@@ -89,6 +103,11 @@ const Row = ({entity}) => {
          ))}
        </Divider>
      </TableData>
+      <TableData>
+        <DetailsLink type="nvt" id={id} title={nvtName}>
+          {shorten(nvtName, 80)}


What happens if the windows gets smaller? Would it be necessary to add line-breaking here, although it might look ok in "full-screen"?

Shouldn't it break automatically? IMHO it only doesn't break if we use css to forbid that.

swaterkamp

In case my comment is "rejected", here is the approval, as the PR looks good to me.

bjoernricks added 30 commits October 7, 2019 14:37

Use camel case for variable name

3420c61

Ensure variables are always defined at ReportCve creation

eac8ee4

When creating a ReportCve instance ensure that the used variables are always defined.

Refactor report app model for new model parsing process

c6d9b54

Use App.fromElement for parsing an App from a Report. Update properties of App to use consistent naming.

Add tests for Report App model

43c52e1

Fix parsing the port counts of the report hosts

830212d

Fix parsing high result counts for hosts in reports

80e6370

Use consistent naming for high results.

Update Report Host model to use new parsing functions

d451f55

Use fromElement to parse a Report Host model.

Add tests for Report Host model

9ed4f64

Cleanup Report Vulnerability model

193b7e5

Move initialization of values to the constructor and use camel case for hosts by ip property.

Add tests for Report Vulnerability model

d3ad54e

Update Report OperatingSystem model

5cbee59

Init hosts in constructor. Use camel case for host by id property. Rename addSeverity to setSeverity and use new parser functions.

Add test for Report OperatingSystem model

1a8caae

Update Report Port model

aefdbbb

Use new functions for parsing. Init hosts in constructor. Use camel case for host by ip information. Update setSeverity method.

Add tests for Report Port model

7d1b756

Drop obsolete method from Report Task model

4fbb975

Add tests for Report Task model

2746ccc

Add comment about the special behavior of report certs

2a49316

Report TLS Certificates are a very special "model". It acts very differently to the normal models because it is not generated from an xml response element. It's data is collected from several host information elements.

Add tests for Report TLS Certificate model

431495f

Extend setProperties function to allow overriding properties

0d9aa77

Update the setProperties function to allow overriding properties of the object.

Use fromElement in Report model tests to create new models

76a587f

Use the fromElement static function to create new models to spot possible side effects from running the parsing code.

Update Report Port model to allow overriding parsed properties

92dbd39

Fix setSeverity method or Port by allowing to override all parsed properties of the Model. The severity prop was parsed from the passed element and therefore has been freezed.

Update report parseHosts function

6596919

Use ReportHosts.fromElement method to parse hosts and add test for parsing an empty hosts list.

Update report parsePorts function

ddd05c3

Use ReportPort.fromElement method to parse ports of a report and add tests for parsing these ports.

Update parsing report vulnerabilities

d6f1c0b

Use fromElement to parse vulns from a report and add tests.

Update report parseApps function

d264af4

Use ReportApp fromElement to parse new app models and add tests for parseApp.

Update parseOperatingSystems function

8b16fa6

Use ReportOperatingSystem fromElement method and add tests.

Refactor ReportTlsCertificate model to behave more like other models

97f0358

Add fromElement and parseElement methods to ReportTlsCertificate model. Use constructor only to init the ports property.

Fix parsing TLS cert port as integer

8767f86

Put the parsed port into the array of ports instead of the original one.

Update parsing report TLS certificates

ce823f2

Use new fromElement method and add tests.

Add tests for parsing report cves

e37a6c8

bjoernricks added 11 commits October 7, 2019 14:39

Drop vulnerabilities code from report details

efb3050

Don't parse report vulnerabilities of a report anymore. Remove unused sort functions for reports vulnerabilities.

Drop obsolete report vulnerability

46ca91f

Drop the unused report vulnerability parsing code.

Update changelog entry

23f4d59

Merge pull request #1668 from bjoernricks/report-model-parsing-updates

b58eb06

Report model parsing updates

Merge branch gsa-8.0 into gsa-9.0

b96f5ce

Fix parsing an nvt from an info response

6d2320c

Add tests for parsing nvt data from an info response element

becafe1

Info responses are again special because they return e.g. <get_info_response><info><nvt>. Therefore the nvt model supports parsing from a nvt sub element too.

Improve parsing nvt ref elements

fd6f3d8

Simplify parsing nvt references by adding generic parsing functions.

Fix parsing report cve data

3e90655

The nvts got changed to collect all references in a separate refs element a while ago. The report data parsing code wasn't updated accordingly.

Add nvtName property to Report Cve model

c623785

Copy name from the parsed nvt to the Report Cve model.

bjoernricks changed the base branch from master to gsa-9.0 October 8, 2019 14:43

Add changelog entry

f90d394

bjoernricks marked this pull request as ready for review October 8, 2019 14:46

bjoernricks requested a review from swaterkamp as a code owner October 8, 2019 14:46

swaterkamp reviewed Oct 8, 2019

View reviewed changes

swaterkamp approved these changes Oct 8, 2019

View reviewed changes

bjoernricks merged commit cebc29b into greenbone:gsa-9.0 Oct 9, 2019

bjoernricks deleted the fix-report-cves branch October 9, 2019 06:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix report cves #1673

Fix report cves #1673

bjoernricks commented Oct 8, 2019 •

edited

Loading

swaterkamp Oct 8, 2019

bjoernricks Oct 9, 2019

swaterkamp left a comment

Fix report cves #1673

Fix report cves #1673

Conversation

bjoernricks commented Oct 8, 2019 • edited Loading

swaterkamp Oct 8, 2019

Choose a reason for hiding this comment

bjoernricks Oct 9, 2019

Choose a reason for hiding this comment

swaterkamp left a comment

Choose a reason for hiding this comment

bjoernricks commented Oct 8, 2019 •

edited

Loading