Gmp store logging #1684
Merged
Gmp store logging #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is easier to read if all variables a set and checked while beeing sorted by name.
Local storage always stores all values as strings. Therefore convert values to string in fake storage for testing.
The setting is a boolean value that is stored persistently in the browsers local storage.
With gmp.settings.enableStoreDebugLog the logging of the redux store can be enabled or disabled explicitly. After setting the value to true or value the browser needs to be reloaded to apply the store debugging. The setting can be reset by calling gmp.settings.enableStoreDebugLog = undefined If the setting is undefined the store debugging is also enabled if the log level is set to debug (gmp.settings.loglevel = 'debug').
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1684 +/- ##
===========================================
+ Coverage 39.5% 39.52% +0.02%
===========================================
Files 965 965
Lines 22082 22095 +13
Branches 6208 6237 +29
===========================================
+ Hits 8723 8734 +11
- Misses 12096 12098 +2
Partials 1263 1263
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: