Consistent settings #1774
Merged
Consistent settings #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use camel case for log level.
Recognize the old loglevel config variable and mark it as deprecated.
Use camel case for protocol doc url setting.
Use apiServer and apiProtocol instead because both settings are used for a connection to the web server providing the API. Static content is still loaded from the current server.
Instead of gmp.reloadInterval the value MUST BE used from gmp.settings.reloadInterval always. Also it was already obsolete in withEntityContainer because the setting has been moved to the Reload component already.
swaterkamp
approved these changes
Nov 12, 2019
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1774 +/- ##
===========================================
+ Coverage 39.98% 40.01% +0.03%
===========================================
Files 965 965
Lines 22135 22150 +15
Branches 6270 6276 +6
===========================================
+ Hits 8850 8863 +13
- Misses 12027 12029 +2
Partials 1258 1258
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use consistent settings and setting names in GSA.
Checklist: