Report loading #1851
Merged
Report loading #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass filter to delta report Summary component.
For the current gmp commands 0 and 1 are often passed for boolean values. To still support this and not to break any code adjust convertBoolean and log some warning with a stacktrace.
This new action creator function is a bit "hacky". It loads the report without details first and checks the number of results. If the number of results is lower the threshold from the gmp settings it loads the full report. Otherwise it just dispatches the report without the details.
Use the new loadEntityWithThreshold action creator in report details page to request the report from the backend. First onyl the small report without details is loaded. Afterwards it is checked if the report results count is lower than the threshold from the settings and if yes the report without details is dispatched to the redux store. Otherwise the full report with details will be loaded.
isUpdating must be true if no report filter is applied or the old report filter isn't equal the new requested filter. Also isUpdating must be reset to false if an error occurs during loading.
…apper Both functions are applied on ReportDetailsWrapper. Therefore move them below the component.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1851 +/- ##
===========================================
+ Coverage 40.03% 40.04% +<.01%
===========================================
Files 975 976 +1
Lines 22434 22464 +30
Branches 6320 6326 +6
===========================================
+ Hits 8981 8995 +14
- Misses 12171 12184 +13
- Partials 1282 1285 +3
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only load report without details if the report results count extends the threshold from the settings.
Checklist: