Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold warning for content composer #1852

Merged
merged 8 commits into from
Dec 12, 2019

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp requested a review from a team December 11, 2019 14:34
@swaterkamp swaterkamp self-assigned this Dec 11, 2019
@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #1852 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1852      +/-   ##
===========================================
- Coverage    40.04%   40.03%   -0.01%     
===========================================
  Files          976      977       +1     
  Lines        22464    22473       +9     
  Branches      6326     6306      -20     
===========================================
+ Hits          8995     8997       +2     
- Misses       12184    12190       +6     
- Partials      1285     1286       +1
Impacted Files Coverage Δ
gsa/src/web/pages/reports/details/alertactions.js 6.55% <ø> (ø) ⬆️
gsa/src/web/pages/reports/details/toolbaricons.js 15.38% <ø> (ø) ⬆️
gsa/src/web/components/dialog/composercontent.js 66.66% <ø> (ø) ⬆️
gsa/src/web/pages/reports/detailscontent.js 6.45% <ø> (ø) ⬆️
gsa/src/web/pages/reports/detailspage.js 5.4% <0%> (-0.05%) ⬇️
gsa/src/web/pages/reports/triggeralertdialog.js 15% <0%> (-1.67%) ⬇️
gsa/src/web/pages/reports/downloadreportdialog.js 21.42% <0%> (-3.58%) ⬇️
gsa/src/web/pages/reports/thresholdmessage.js 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca411f5...94cfa4f. Read the comment docs.

gsa/src/web/components/dialog/composercontent.js Outdated Show resolved Hide resolved
gsa/src/web/pages/reports/downloadreportdialog.js Outdated Show resolved Hide resolved
gsa/src/web/pages/reports/triggeralertdialog.js Outdated Show resolved Hide resolved
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move thresholdmessage.js to web/pages/reports too

gsa/src/web/components/dialog/thresholdmessage.js Outdated Show resolved Hide resolved
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks a lot

@bjoernricks bjoernricks merged commit 8b40d3d into greenbone:gsa-8.0 Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants