Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error panel #1862

Merged
merged 4 commits into from
Dec 16, 2019
Merged

Error panel #1862

merged 4 commits into from
Dec 16, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Dec 13, 2019

Checklist:

This component is derived from the ErrorBoundary internals and can be
used to display expected (e.g. loading) errors.
Reuse the ErrorPanel component in ErrorBoundary.
@bjoernricks bjoernricks marked this pull request as ready for review December 13, 2019 16:48
@bjoernricks bjoernricks requested a review from a team December 13, 2019 16:58
@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #1862 into gsa-8.0 will increase coverage by 0.01%.
The diff coverage is 95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1862      +/-   ##
===========================================
+ Coverage    40.03%   40.04%   +0.01%     
===========================================
  Files          977      978       +1     
  Lines        22475    22480       +5     
  Branches      6331     6310      -21     
===========================================
+ Hits          8997     9003       +6     
+ Misses       12192    12191       -1     
  Partials      1286     1286
Impacted Files Coverage Δ
gsa/src/web/pages/reports/detailscontent.js 5% <0%> (-1.46%) ⬇️
gsa/src/web/utils/proptypes.js 82.14% <100%> (ø) ⬆️
gsa/src/web/components/error/errorboundary.js 100% <100%> (ø) ⬆️
gsa/src/web/components/error/errorpanel.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ada7a4...6145c2a. Read the comment docs.

@swaterkamp swaterkamp merged commit f1643e0 into greenbone:gsa-8.0 Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants