Report results loading #1863
Merged
Report results loading #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1863 +/- ##
==========================================
- Coverage 40.03% 39.9% -0.13%
==========================================
Files 977 977
Lines 22475 22557 +82
Branches 6331 6324 -7
==========================================
+ Hits 8997 9001 +4
- Misses 12192 12259 +67
- Partials 1286 1297 +11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1863 +/- ##
===========================================
- Coverage 40.04% 39.82% -0.23%
===========================================
Files 978 979 +1
Lines 22480 22636 +156
Branches 6310 6368 +58
===========================================
+ Hits 9003 9015 +12
- Misses 12191 12311 +120
- Partials 1286 1310 +24
Continue to review full report at Codecov.
|
Allow to specify the prop name used by withDefaultFilter and use defaultFilter by default instead of filter.
Update ResultsTab component to load report results via <get_results filter="report_id=foo"/> command. Implement sorting and pagination via filter changes.
Always add passed name property to all debug messages.
Automatically reload results data at the ResultsTab of a report.
This same functionality is already provided by the Reload component.
Don't show sort, sort-reverse, first and rows filter params at the bottom of the ResultsTab. Due to the different filter handling in the components the full filter may be very confusing.
bjoernricks
requested review from
swaterkamp and
timopollmeier
as code owners
timopollmeier
requested changes
Dec 17, 2019
This filter param is only for internal usage and must not be used outside of gsa. It can vanish everytime.
If the report filter is changed when the ResultsTab isn't mounted (measn that another tab is displayed currently) it needs to load the results with this changed filter instead of the stored filter.
Fallback to current report filter is the results filter isn't available. This allows for easier debugging issues with the current filter used for getting the results.
This avoids displaying and using wrong filter terms like duplicated sort terms.
If an error occurs during loading the results display an ErrorPanel with details about the error.
If loading a report has an error and we are already displaying a report show the error at the summary.
Also change displayed message if no report could be loaded at all.
Only pass simple required data to components. If the component only requires the report id the report id shouls be passed as a prop directly instead of passing the whole report model.
Update report ToolBarIcons and DetailsContent to use reportId prop directly.
Boolean props should be named isSomething or hasSomething. This is a leftover from early implementations.
Update the props of ToolBarIcons to accept only a object shape for report and don't require it. The ToolBarIcons render just find if the report isn't provided.
Don't display empty lists at the different tabs which state that no entities are available. Show a loading indicator if the full report is still be loaded.
Be more precise about where this filter comes from.
By default it seems that resetting the report filter creates a filter with sort=name. The name column doesn't exist for results. Therefore we should reset the filter explicitly to a specific sorting.
swaterkamp
approved these changes
Dec 17, 2019
timopollmeier
approved these changes
Dec 17, 2019
|
Thanks for the reviews 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing:
Report ID filterReloadingfix isUpdating indicator while loading full reportfix setting sort=foo when sort-reverse=bar is appliedError handlingChecklist: