Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delta report #1871

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Fix delta report #1871

merged 3 commits into from
Dec 18, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Dec 18, 2019 •
edited
Loading

Checklist:

@bjoernricks
Fix validation of delta_report_id
43c2238 
The report_id got changed to be an alias of id and moved below the
definition of the delta_report_id parameter. Therefore delta_report_id
valiator couldn't reference the report_id alias and actually always
failed the validation of the paramter. As a result delta reports
couldn't be requested and loaded from gvmd.
@bjoernricks
Avoid proptype warnings about reportId props
10ac82d 
Pass the reportId to the Summary and the ToolBarIcons components.
@bjoernricks
Update changelog
c2abe3a
@bjoernricks bjoernricks marked this pull request as ready for review December 18, 2019 12:46
@bjoernricks bjoernricks requested review from a team and sarahd93 December 18, 2019 12:46
@bjoernricks bjoernricks merged commit d6d4b8b into greenbone:gsa-8.0 Dec 18, 2019
@bjoernricks bjoernricks deleted the fix-delta-report branch December 18, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahd93 sarahd93 sarahd93 approved these changes

@swaterkamp swaterkamp swaterkamp approved these changes

@timopollmeier timopollmeier Awaiting requested review from timopollmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjoernricks @sarahd93 @swaterkamp