Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task listpage observer tooltip #1968

Merged
merged 4 commits into from
Feb 17, 2020

Conversation

sarahd93
Copy link
Contributor

ProvideViewIcon in task row was only shown for users. Show it for groups and roles as well.

Checklist:

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #1968 into gsa-8.0 will increase coverage by 0.02%.
The diff coverage is 55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1968      +/-   ##
===========================================
+ Coverage    43.58%   43.61%   +0.02%     
===========================================
  Files          983      983              
  Lines        22811    22824      +13     
  Branches      6476     6458      -18     
===========================================
+ Hits          9943     9954      +11     
- Misses       11663    11665       +2     
  Partials      1205     1205
Impacted Files Coverage Δ
gsa/src/web/pages/tasks/row.js 11.11% <0%> (-0.66%) ⬇️
gsa/src/gmp/models/task.js 70.73% <100%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2533f09...6625964. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review February 17, 2020 09:51
@sarahd93 sarahd93 requested review from a team, saberlynx and swaterkamp February 17, 2020 09:51
@swaterkamp swaterkamp merged commit 53fef23 into greenbone:gsa-8.0 Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants