Change: Handle delta results with changed severity, qod and hostname #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to description differences, differences in severity, qod or hostname are considered as a change in delta results comparison.
a-h-abdelsalam
force-pushed
the
delta-reports-v2
branch
from
70227fa
to
ae0063b
Compare
Conventional Commits Report😢 No conventional commits found. 👉 Learn more about the conventional commits usage at Greenbone. |
a-h-abdelsalam
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3902 +/- ##
==========================================
+ Coverage 59.90% 59.92% +0.01%
==========================================
Files 1021 1022 +1
Lines 25098 25113 +15
Branches 7426 7437 +11
==========================================
+ Hits 15035 15049 +14
- Misses 9115 9116 +1
Partials 948 948
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bjoernricks
reviewed
Oct 17, 2023
|
Could you extend your PR for some tests? |
Co-authored-by: Björn Ricks <bjoern.ricks@greenbone.net>
jhelmold
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Handle delta results with changed severity, qod and hostname. In addition to description differences, differences in severity, qod or hostname are considered as a change in delta results comparison.
Why
Within the new delta reports handling, results that have changes only in severity, qod or hostname are now considered changes instead of gone/new.
References
GEA-320