Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening report format dialog #3950

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

bjoernricks
Copy link
Contributor

What

Fix opening report format dialog

Why

Opening the report format dialog wasn't possible because a required prop was not passed. This wasn't spotted because currently there is no non predefined report format thus no report format is editable.

Checklist

  • Tests

Opening the report format dialog wasn't possible because a required prop
was not passed. This wasn't spotted because currently there is no non
predefined report format thus no report format is editable.
@bjoernricks bjoernricks requested a review from a team as a code owner January 17, 2024 09:25
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6e80422) 0.00% compared to head (a2c8a3d) 60.05%.

Files Patch % Lines
src/web/pages/reportformats/component.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #3950       +/-   ##
=========================================
+ Coverage      0   60.05%   +60.05%     
=========================================
  Files         0     1025     +1025     
  Lines         0    25204    +25204     
  Branches      0     7468     +7468     
=========================================
+ Hits          0    15136    +15136     
- Misses        0     9124     +9124     
- Partials      0      944      +944     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timopollmeier timopollmeier merged commit d582a07 into main Jan 17, 2024
13 checks passed
@timopollmeier timopollmeier deleted the fix-report-format-dialog branch January 17, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants