Rename "Internal Error" to "Interrupted" #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaterkamp
added
the
work in progress
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
=========================================
+ Coverage 5.63% 5.64% +<.01%
=========================================
Files 767 767
Lines 25271 25300 +29
Branches 5697 5714 +17
=========================================
+ Hits 1425 1428 +3
- Misses 21428 21454 +26
Partials 2418 2418
Continue to review full report at Codecov.
|
swaterkamp
force-pushed
the
TaskInterruptedStatus
branch
from
7b3045d
to
8b2bf47
Compare
mattmundell
reviewed
Jun 13, 2018
|
So, as long as there are no more requests for this feature, I'll remove the 'work in progress' tag. Feel free to merge :) |
swaterkamp
removed
the
work in progress
While doing so, also make status and ProgressBar titles translatable. Having the getTranslatableStatus() method for tasks PLUS the exported getTranslatableTaskStatus function was "necessary", because having it as a Task-method is nice, but it is also needed in the StatusBar, where the status needs translation but the task is not available (just pure status string).
swaterkamp
force-pushed
the
TaskInterruptedStatus
branch
from
8b2bf47
to
1417edf
Compare
bjoernricks
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.