Extended schedules #720
Merged
Extended schedules #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schedules contain ical data now. We are going to use ical.js for pasing and creating these ical data.
Parse schedule from ical data now. Currently start date, next date, recurrencies and durations are evaluated. Remove old properties from the Schedule model which got replaced by the new ones from the ical data.
Use the new ical based Schedule properties to display the Schedule details.
The timezone is displayed as an extra value at the Schedule details. Therefore it is not necessary to include it when displaying the start and next run dates. long_date and datetime only differ in datetime not displaying the timezone info.
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
=========================================
- Coverage 5.62% 5.61% -0.01%
=========================================
Files 782 782
Lines 25238 25304 +66
Branches 5655 5687 +32
=========================================
+ Hits 1419 1421 +2
- Misses 21410 21459 +49
- Partials 2409 2424 +15
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR for the extended schedules feature.