Extended schedules #724
Merged
Extended schedules #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ical.Recur instance will allow access to the number of recurrences (count) of an event. In future it will allow access to weekday recurrences too.
Add a property to the schedule event to get the duration in seconds.
Add a method to Event that calculates the next dates for a recurrence of an Event until some date in the future.
A recurrence object has a freq (frequency) property. This property returns a string value. Adding a constant object allow to compare the freqencies more easily.
This will allow to use a different time range for the schedule chart.
Use the parsed ical event data for rendering the next schedules tasks chart.
Fix setting the timezone when editing an existing Schedule.
The ical events (at least libical and ical.js) don't support months for durations. Therefore don't allow to select the month unit.
Currently this doesn't work because gsad/gvmd still doesn't return ical data for task schedules by default. But this will change in future.
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=========================================
- Coverage 5.61% 5.6% -0.01%
=========================================
Files 782 782
Lines 25398 25431 +33
Branches 5697 5700 +3
=========================================
Hits 1425 1425
- Misses 21545 21573 +28
- Partials 2428 2433 +5
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2