Extended schedules #729
Merged
Extended schedules #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
=========================================
+ Coverage 5.65% 5.66% +<.01%
=========================================
Files 767 768 +1
Lines 25303 25351 +48
Branches 5716 5722 +6
=========================================
+ Hits 1431 1435 +4
- Misses 21454 21485 +31
- Partials 2418 2431 +13
Continue to review full report at Codecov.
|
timopollmeier
requested changes
Jun 15, 2018
The icalendar param must contain VCALENDAR data.
When creating a new schedule expect a icalendar parameter.
All ical related code is moved to an extra model module.
Support icalendar data when creating a new schedule instead of the legacy year, hour, duration, ... parameters.
No functionality of the ScheduleDialog has been changed yet. It just supports converting the current data into the icalendar format.
When calling save_schedule command use the icalendar param and forward it to gvmd.
When saving the a Schedule use the icalendar data.
Forward the id to the onSave handler to be able to decide if saving is a create or modify/save command.
timopollmeier
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3
Support creating Schedules via icalendar (https://tools.ietf.org/html/rfc5545) data