Extended schedules #731

bjoernricks · 2018-06-15T12:12:54Z

Part 4

use moment.duration http://momentjs.com/docs/#/durations/ as container for durations
update schedule dialog to use end date for durations

This simplifies the renderDuration method by using the already available moment translations and duration formats.

Drop the param durationUnit and expect a moment duration as duration.

There is no need to pass hour and minute as params. Leave this date calculation to the caller of Event.fromData.

The duration prop is validated to be a moment duration.

The duration will be calculated from an end date and can contain a combination of time units e.g. 1 hour and 5 minutes now.

codecov · 2018-06-15T12:17:53Z

Codecov Report

Merging #731 into master will increase coverage by 0.01%.
The diff coverage is 7.14%.

@@            Coverage Diff            @@
##           master    #731      +/-   ##
=========================================
+ Coverage    5.67%   5.68%   +0.01%     
=========================================
  Files         768     768              
  Lines       25354   25337      -17     
  Branches     5724    5702      -22     
=========================================
+ Hits         1438    1440       +2     
+ Misses      21485   21477       -8     
+ Partials     2431    2420      -11

Impacted Files	Coverage Δ
ng/src/web/pages/schedules/render.js	`0% <0%> (ø)`	⬆️
ng/src/web/pages/schedules/component.js	`0% <0%> (ø)`	⬆️
ng/src/gmp/models/event.js	`8.73% <0%> (+0.55%)`	⬆️
ng/src/web/pages/schedules/dialog.js	`0% <0%> (ø)`	⬆️
ng/src/web/utils/proptypes.js	`81.81% <33.33%> (-5.94%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed60fd...8d98f7c. Read the comment docs.

bjoernricks requested a review from swaterkamp as a code owner June 15, 2018 12:12

bjoernricks added 5 commits June 15, 2018 14:17

Use moment duration for Event duration

feb25f8

This simplifies the renderDuration method by using the already available moment translations and duration formats.

Expect a moment duration in Event.fromData

ef58591

Drop the param durationUnit and expect a moment duration as duration.

Expect a startDate being passed to Event.fromData

c8d6d27

There is no need to pass hour and minute as params. Leave this date calculation to the caller of Event.fromData.

Add a proptype for durations

ebab225

The duration prop is validated to be a moment duration.

Update ScheduleDialog to use an end date selection

8d98f7c

The duration will be calculated from an end date and can contain a combination of time units e.g. 1 hour and 5 minutes now.

swaterkamp approved these changes Jun 15, 2018

View reviewed changes

bjoernricks merged commit 6e5d865 into greenbone:master Jun 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extended schedules #731

Extended schedules #731

bjoernricks commented Jun 15, 2018

codecov bot commented Jun 15, 2018 •

edited

Loading

Extended schedules #731

Extended schedules #731

Conversation

bjoernricks commented Jun 15, 2018

codecov bot commented Jun 15, 2018 • edited Loading

Codecov Report

codecov bot commented Jun 15, 2018 •

edited

Loading