Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tags #768

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Improve tags #768

merged 3 commits into from
Jul 3, 2018

Conversation

swaterkamp
Copy link
Member

  • disable bulk tags option for tags
  • the tags dialog (bulk tags) now allows to create a new tag "on the fly"

Tags cannot be tagged, therefore don't show that option.
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #768 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #768      +/-   ##
=========================================
- Coverage    6.05%   6.05%   -0.01%     
=========================================
  Files         777     777              
  Lines       25798   25820      +22     
  Branches     5796    5814      +18     
=========================================
  Hits         1563    1563              
- Misses      21768   21790      +22     
  Partials     2467    2467
Impacted Files Coverage Δ
gsa/src/web/pages/tags/listpage.js 0% <ø> (ø) ⬆️
gsa/src/web/entities/tagsdialog.js 0% <0%> (ø) ⬆️
gsa/src/web/entities/container.js 0% <0%> (ø) ⬆️
gsa/src/web/store/dashboard/data/loader.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6e0ae...e8187e7. Read the comment docs.

Values of selected Tags are shown to easily identify the desired tag
among those with identical names.
@swaterkamp swaterkamp merged commit 2974b63 into greenbone:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants