Entity loading #776
Merged
Entity loading #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change isLoadingEntities to return false if state doesn't contain a isLoading property.
Pass the entity type as parameter to the enties actions insteaf of encoding it in the action name. Remove obsolete createLoadingTypes function. Rename createActionCreators to createEntitiesActionCreators because action creators for single entities will follow.
An entity type is always a singular term.
We'll get a loadEntity function in future too.
The layout of the state is now:
{
entities: {
[enityType]: {
byId: {
id1: ...,
id2, ...,
},
errors: {
[filterStringId1]: errormessage,
[filterStringId2]: errormessage,
},
isLoading: {
[filterStringId1]: bool,
[filterStringId2]: bool,
},
[filterStringId1]: [idX, idY, ...],
[filterStringId2]: [idA, idB, ....],
},
},
...otherStateData,
}
We'll get entityActions in future too.
We are only testing a single reducer here.
The new createLoadEntity function returns a loader function for a specific entity.
EntitiesSelector getError returns an error for a entities request. Therefore getEntitiesError is more precise. Also update getEntitiesError test descriptions.
Just reorder the tests and remove one description.
The method returns an error for an id if it is defined.
Rename testReducers to testReducerForEntities and testActions to testEntitiesActions.
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
========================================
+ Coverage 6.33% 6.73% +0.4%
========================================
Files 778 778
Lines 25861 25972 +111
Branches 5830 5842 +12
========================================
+ Hits 1639 1750 +111
Misses 21780 21780
Partials 2442 2442
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to load single entities into the store.