Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag improvements #786

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Tag improvements #786

merged 2 commits into from
Jul 10, 2018

Conversation

swaterkamp
Copy link
Member

No description provided.

The users will get a notification about long loading times, when they
are about to bulk-assign a tag to more than 1000 resources at once.
@swaterkamp swaterkamp self-assigned this Jul 10, 2018
@codecov
Copy link

codecov bot commented Jul 10, 2018

Codecov Report

Merging #786 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #786      +/-   ##
=========================================
- Coverage    6.76%   6.76%   -0.01%     
=========================================
  Files         780     780              
  Lines       26037   26048      +11     
  Branches     5857    5863       +6     
=========================================
  Hits         1761    1761              
- Misses      21827   21835       +8     
- Partials     2449    2452       +3
Impacted Files Coverage Δ
gsa/src/web/components/icon/listicon.js 0% <ø> (ø) ⬆️
gsa/src/web/components/link/link.js 0% <0%> (ø) ⬆️
gsa/src/web/entities/tagsdialog.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f04d1e...b69b473. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very suboptimal to query all items only to get the counts.

@swaterkamp swaterkamp merged commit ca236cf into greenbone:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants